Skip to content

Comments

feat(talkintegration): filter out event type rooms from suggestions#6843

Merged
st3iny merged 1 commit intomainfrom
feat/filter-event-rooms-from-room-picker
Mar 22, 2025
Merged

feat(talkintegration): filter out event type rooms from suggestions#6843
st3iny merged 1 commit intomainfrom
feat/filter-event-rooms-from-room-picker

Conversation

@miaulalala
Copy link
Contributor

As discussed in nextcloud/spreed#14689

Before After
Screenshot from 2025-03-20 16-33-40 Screenshot from 2025-03-20 16-34-07

Test event is a room created by Calendar via the Talk integration.

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala added 3. to review Waiting for reviews Feature: Integration An integration with another app in the ecosystem labels Mar 20, 2025
@miaulalala miaulalala self-assigned this Mar 20, 2025
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.95%. Comparing base (c674fac) to head (909f399).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/AddTalkModal.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6843      +/-   ##
============================================
- Coverage     28.68%   22.95%   -5.73%     
+ Complexity      952      476     -476     
============================================
  Files           294      252      -42     
  Lines         14558    12267    -2291     
  Branches       2351     2362      +11     
============================================
- Hits           4176     2816    -1360     
+ Misses        10040     9109     -931     
  Partials        342      342              
Flag Coverage Δ
javascript 14.59% <0.00%> (-0.01%) ⬇️
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@st3iny st3iny modified the milestones: v5.2.0, v5.3.0 Mar 22, 2025
@st3iny st3iny merged commit d4d5c4d into main Mar 22, 2025
45 of 47 checks passed
@st3iny st3iny deleted the feat/filter-event-rooms-from-room-picker branch March 22, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews Feature: Integration An integration with another app in the ecosystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants