Skip to content

Comments

Booking: change color of disabled days in datepicker#6845

Merged
st3iny merged 1 commit intomainfrom
style/booking-datepicker-disabled-days
May 19, 2025
Merged

Booking: change color of disabled days in datepicker#6845
st3iny merged 1 commit intomainfrom
style/booking-datepicker-disabled-days

Conversation

@GVodyanov
Copy link
Contributor

Fix #6521

Before After
image image
image image

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Mar 20, 2025
@GVodyanov GVodyanov self-assigned this Mar 20, 2025
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.88%. Comparing base (8ccce9d) to head (727baf8).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/views/Appointments/Booking.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6845   +/-   ##
=========================================
  Coverage     22.88%   22.88%           
  Complexity      476      476           
=========================================
  Files           252      252           
  Lines         12305    12305           
  Branches       2364     2365    +1     
=========================================
  Hits           2816     2816           
  Misses         9141     9141           
  Partials        348      348           
Flag Coverage Δ
javascript 14.54% <0.00%> (ø)
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GVodyanov GVodyanov requested a review from nimishavijay March 21, 2025 08:59
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely looks great in dark mode! The disabled dates stand out more than the available dates in light mode though. Could we try using background-dark instead of background-darker, and change the text color of the available dates to main-text? That could help make them stand out more.

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the style/booking-datepicker-disabled-days branch from 1169b5c to 727baf8 Compare May 18, 2025 17:47
@GVodyanov GVodyanov requested a review from nimishavijay May 18, 2025 17:47
@GVodyanov GVodyanov dismissed nimishavijay’s stale review May 18, 2025 17:48

Hadn't noticed the disabled days getting a background too 😅

Should be all good now!

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny
Copy link
Member

st3iny commented May 19, 2025

/backport to stable5.2

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label May 19, 2025
@st3iny st3iny added design Related to design, interface, interaction design, UX, etc. Feature: Appointments labels May 19, 2025
@st3iny st3iny enabled auto-merge May 19, 2025 11:23
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 19, 2025
@st3iny st3iny merged commit ec07d82 into main May 19, 2025
48 of 50 checks passed
@st3iny st3iny deleted the style/booking-datepicker-disabled-days branch May 19, 2025 11:23
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish design Related to design, interface, interaction design, UX, etc. Feature: Appointments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled days in appointment preview calendar look bad (dark mode)

3 participants