(fix) system addressbook enumeration disabled in contacts search

[akhil1508]

• For big instances, inviting attendees is strangely slow
• After doing some logging, I figured out that the query to search on system address book was the culprit
• It turns out that system address book results are skipped anyways at

  calendar/lib/Controller/ContactController.php

  Line 107 in 4c3dd76

  if ($this->contactsService->isSystemBook($r) || !$this->contactsService->hasEmail($r)) {

• So why not just avoid the search query at system address book and get faster searches by setting enumeration to false as per https://github.com/nextcloud/server/blob/d785bcdc6ea27a8d84173813e75c459299ebdbe8/lib/private/ContactsManager.php#L28
• Searches have been much faster after this change for me

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.84%. Comparing base (d08a9ba) to head (fec512e).
⚠️ Report is 217 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7299   +/-   ##
=======================================
  Coverage   14.84%   14.84%           
=======================================
  Files         212      212           
  Lines       10299    10299           
  Branches     2484     2484           
=======================================
  Hits         1529     1529           
  Misses       8420     8420           
  Partials      350      350           

Flag	Coverage Δ
javascript	14.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SebastianKrupinski]

Hi @akhil1508

Thank you for the contribution, I we will need to test this for side effects. Please give us a few days to do so.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[st3iny]

Hi @akhil1508, I imported the changes here: #7403

I wasn't able to push changes here but the branch needed a rebase. I also removed the enumeration again from one call where it wasn't safe.

[st3iny]

Looks good and tested. See my other (imported) PR.

[akhil1508]

Thanks @st3iny