fix: modifying a proposal

[taiebot]

Current code is wrong because:

$currentDates[$key] = the old date from the database

$date = the new mutated date from the client

So when we detect a modification, we are returning the old object instead of the new one.

On main
create a proposal. (save)
exit
re-enter Try to modify it => nothing happens (fail silently)

With pull request
create a proposal (save)
exit
Modify it => proposal is modified accurately

[taiebot]

Seen in #8095 (comment)
Tested and this does fix the modification

[SebastianKrupinski]

Tested. Looks good!

Not sure how I missed this during final testing, I guess I never dragged a date to a different time.

Thank you!!!

[SebastianKrupinski]

/backport to stable6.3

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)