fix(events): do not discard text input of dates and times in event edit dialog#8433
fix(events): do not discard text input of dates and times in event edit dialog#8433odzhychko wants to merge 1 commit into
Conversation
…it dialog Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Hey, I'm not against doing it this way, but.. I had a look at this and yes this is a way to temporarily fix this. The issue with the temporary part is that we never, end up getting time to the actually fix it properly and temporary becomes permanent. So I am big supporter of not cutting corners and fixing the issue where it is being caused. (nextcloud/vue), As for the extra parsing library, I don't know if this is needed, the nc/vue pr I did to fix this used Date() to parse and it worked correctly, 99% of the time. Can we just use the built in date() function instead of another dependency? |
|
@SebastianKrupinski Thanks for looking it over.
Yeah, I know what you mean. If it helps, I do not intend to mark #8307 as finished until I fix it at the root.
I think using new Date(Intl.DateTimeFormat('es', { dateStyle: 'medium' }).format(new Date('2026-12-30')))But maybe I miss something.
I also don't like the extra dependency. When make a fix in the |
Provisional fix for #8307 until I can properly fix it in @nextcloud/vue .
The comments in the code describe how this fix works.
The underlying issue is that
NcDateTimePickerspecifies how to format dates/times but not how to parse them back.Possible issues with this fix
datetime-locale-patternsmight use older locale data than used by browsers forIntl.DateTimeFormatdatetime-locale-patternsbundles more locale data then possibly needed for locales supported by NextcloudBefore
Screencast.from.2026-06-03.16-17-41.webm
After
Screencast.from.2026-06-03.16-16-14.webm