feat!: replace xhr provider with @nextcloud/axios#935
Conversation
f8dba05 to
071f4a5
Compare
st3iny
left a comment
There was a problem hiding this comment.
Awesome, thanks! I will take a look at the code as soon as I can.
API-wise this is a breaking change. The xhrProvider argument is exposed publicly via DavClient. Removing it is a breaking change and we should do a major bump. I'm fine with that.
Please also remove the xhrProvider argument from DavClient's constructor in src/index.js in line 33.
b8996f0 to
a65cfa7
Compare
|
I rebased to fix conflicts. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 83.90% 85.14% +1.23%
==========================================
Files 30 30
Lines 1255 1245 -10
Branches 204 206 +2
==========================================
+ Hits 1053 1060 +7
+ Misses 202 185 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- replace xml http request with @nextcloud/axios in request.js - reorganize code in class Request so that it bevahes as with xhr - update test suite requestTest.js Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Angel Mendez Cano <amendez1988@gmail.com>
a65cfa7 to
23758d9
Compare
st3iny
left a comment
There was a problem hiding this comment.
Tested and works. Thank you very much for your contribution!
I adjusted some minor things, implemented abort signal handling and improved the testing of it.
Fixes: #718