fix(teams): circular Talk previews and border-radius-small for Files previews#2494
Open
jancborchardt wants to merge 1 commit into
Open
fix(teams): circular Talk previews and border-radius-small for Files previews#2494jancborchardt wants to merge 1 commit into
jancborchardt wants to merge 1 commit into
Conversation
…previews - Add `type?` field to `ITeamResource` so resource provider can be identified in the frontend - Apply `border-radius-pill` to Talk conversation icon boxes for circular display - Change Files preview box from `border-radius-element` to `border-radius-small` with `overflow: hidden` for proper clipping AI-assisted: Claude Code (Sonnet 4.6) Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Member
Author
|
Not sure about those extra file changes @hamza221 @cristianscheid, is that ok or unrelated? |
Member
|
Hi @jancborchardt, while testing this locally I noticed that the changes on circles repo are not actually needed, meaning the changes from contacts PR alone should do the work. Below is a screenshot of my env with circle's 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the previews in Teams not looking correct. Together with nextcloud/contacts#5359
Summary
type?field toITeamResourceso resource provider can be identified in the frontendborder-radius-pill(circular) via the newteam-resources__box--talkmodifier classborder-radius-elementtoborder-radius-small, withoverflow: hiddenadded for proper image clippingTest plan
border-radius-small)type: 'talk'is set on the resource🤖 Generated with Claude Code