Skip to content

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Aug 9, 2020

Fixes: #465

…ting

Fixes: nextcloud#465
Signed-off-by: Jonas Meurer <jonas@freesources.org>
@mejo- mejo- force-pushed the mysmallphptools_request_self_signed_cert branch from 47796a9 to d5cc07e Compare August 9, 2020 10:32
@mejo-
Copy link
Member Author

mejo- commented Aug 9, 2020

To be honest I wonder why the circles app backend uses daita\MySmallPhpTools\Request at all.

First, I'd expect the backend to do direct library calls instead of calling a HTTP API for actions on local NC instance, no?

And second, why not use the Request() class that NC brings, i.e. OC\AppFramework\HTTP\Request?

I'm pretty sure there's reasons why it's the way it is and I didn't dive too much into the app code yet, so maybe I'm just ignorant and didn't look enough 😉

If you intend to keep using daita\MySmallPhpTools\Model\Request, maybe a cleaner solution would be to accept the verifyPeer bool as optional argument to its constructor, make $this->configService->getAppValue(ConfigService::CIRCLES_SELF_SIGNED) return a bool and pass it directly to the Request() constructor?

@ArtificialOwl
Copy link
Member

First, I'd expect the backend to do direct library calls instead of calling a HTTP API for actions on local NC instance, no?

yes, I need to migrate this.

@ArtificialOwl ArtificialOwl merged commit 1499774 into nextcloud:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Member function is not working

2 participants