Skip to content

Conversation

@claucambra
Copy link
Contributor

No description provided.

@claucambra claucambra self-assigned this Jan 14, 2025
@claucambra claucambra changed the title Add required sparkle:installationType to response Sparkle enclosure Add Sparkle 2 required sparkle:installationType to response Sparkle enclosure Jan 14, 2025
@mgallien
Copy link
Collaborator

mgallien commented Feb 5, 2025

@claucambra can you fix the failing automated tests ?
we should not merge it with broken tests

@claucambra
Copy link
Contributor Author

@claucambra can you fix the failing automated tests ? we should not merge it with broken tests

Thanks for pointing it out, I have amended the tests

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra force-pushed the bugfix/sparkle-2-support branch from ea8f32a to 38a9a8d Compare February 6, 2025 05:51
@mgallien mgallien merged commit 092be1c into master Feb 11, 2025
5 checks passed
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@mgallien mgallien deleted the bugfix/sparkle-2-support branch October 3, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants