perf: Replace getById call by getFirstNodeById#2237
Merged
Conversation
CarlSchwan
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
CarlSchwan
force-pushed
the
carl/perf-getbyid
branch
3 times, most recently
from
8209cb8 to
bd75deb
Compare
We only use the first node anyway and getFirstNodeById is faster Signed-off-by: Carl Schwan <carlschwan@kde.org>
mejo-
force-pushed
the
carl/perf-getbyid
branch
from
bd75deb to
9e7b37e
Compare
mejo-
approved these changes
Feb 11, 2026
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks @CarlSchwan, much appreciated 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only use the first node anyway and getFirstNodeById is faster
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)