Skip to content

Perf: Optimize member list for collective with large number of members#2443

Merged
mejo- merged 2 commits into
mainfrom
feature/optimize-members-list
May 5, 2026
Merged

Perf: Optimize member list for collective with large number of members#2443
mejo- merged 2 commits into
mainfrom
feature/optimize-members-list

Conversation

@Koc
Copy link
Copy Markdown
Contributor

@Koc Koc commented Apr 22, 2026

📝 Summary

This PR improves FE performance for a Collectives with large number of members by adding RecycleScroller (like in other places in the app) to the members list in popup.

🎁 Also it fixes calculation of members to display on the landing page. Right now we have 3 members on initial page load. But after window resize even for 1px smaller we're recalculating members to show. With my adjustment we have same members list for more or less similar screen sizes.

🖼️ Screenshots

image
🏚️ Before 🏡 After
image image

🚧 TODO

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@Koc Koc force-pushed the feature/optimize-members-list branch 2 times, most recently from 55f46d5 to 7dfa540 Compare April 22, 2026 22:21
@Koc Koc marked this pull request as ready for review April 22, 2026 22:34
@Koc Koc force-pushed the feature/optimize-members-list branch from 7dfa540 to 3c55222 Compare May 3, 2026 22:36
@mejo- mejo- marked this pull request as draft May 4, 2026 13:59
@mejo- mejo- marked this pull request as ready for review May 4, 2026 14:11
Comment thread src/views/CollectiveView.vue Outdated
@Koc Koc force-pushed the feature/optimize-members-list branch from 926e6ca to cce70bc Compare May 4, 2026 15:32
@mejo- mejo- force-pushed the feature/optimize-members-list branch from cce70bc to ed8cbe8 Compare May 5, 2026 14:23
Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution @Koc, much appreciated. I adjusted the height CSS property to make sure the whole modal height is used.

Koc added 2 commits May 5, 2026 17:20
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
…s (code review changes)

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/optimize-members-list branch from ed8cbe8 to e9c6e38 Compare May 5, 2026 15:20
@mejo- mejo- merged commit 2611fcf into main May 5, 2026
58 of 61 checks passed
@mejo- mejo- deleted the feature/optimize-members-list branch May 5, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants