fix(links): register global collectives link handler and pass it to Text#2501
Open
mejo- wants to merge 2 commits into
Open
fix(links): register global collectives link handler and pass it to Text#2501mejo- wants to merge 2 commits into
mejo- wants to merge 2 commits into
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Ensures that link navigation always uses the collectives link handler, regardless of whether clicking the preview, the "Open link" button in the link bubble, or Ctrl-clicking the link directly. Requires nextcloud/text#8571 Fixes: #2378 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/pass_link_handler
branch
from
cff7b30 to
e54439c
Compare
When `collectiveId` is accessed before `currentCollective` is loaded, this resulted in a type error. This was observed when running Playwright tests with UI from time to time. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/pass_link_handler
branch
from
e54439c to
777440a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Ensures that link navigation always uses the collectives link handler, regardless of whether clicking the preview, the "Open link" button in the link bubble, or Ctrl-clicking the link directly.
Requires nextcloud/text#8571
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)