-
Notifications
You must be signed in to change notification settings - Fork 197
fix: routing based on base64 encoding #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4615 +/- ##
==========================================
+ Coverage 9.65% 9.69% +0.04%
- Complexity 265 266 +1
==========================================
Files 126 126
Lines 6320 6314 -6
Branches 1180 1180
==========================================
+ Hits 610 612 +2
+ Misses 5588 5580 -8
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
While IMO other apps should not use another app's route because this is a form of inter-app dependency, there is https://github.com/search?q=org%3Anextcloud%20contacts.contacts.direct&type=code |
Right, that is a good point. I'll convert this to a fix then. I added some compatibility code to keep the old routes working: contacts/lib/Controller/ContactsController.php Lines 36 to 39 in 13d9707
|
c75083b to
9c87b4e
Compare
|
/backport to stable7.2 |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
b86e6db to
37f4b12
Compare
|
Rebased to fix conflicts. |
|
/backport to stable7.3 |
|
/backport to stable8.0 |
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Works good.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fix #4603
I added some compatibility code to keep the old route working (in case another app generates a link to the direct route).
How to test:
Expected: The contacts app should open and show the contact.
Actual: A generic 404 page is shown.
Example contacts to test with:
(Both will break on main and work here.)