Skip to content

Conversation

@cristianscheid
Copy link
Contributor

@cristianscheid cristianscheid commented Jan 24, 2026

Summary

Adds possibility to search for federated users (accounts from other instances) and federated groups when adding members to a team in the Contacts app.

Context

Changes

  • Enabled federated users and groups in CIRCLES_MEMBER_GROUPING by uncommenting the previously disabled entries in src/models/constants.ts
  • Fixed avatar rendering for federated entities: Modified src/components/EntityPicker/EntitySearchResult.vue and src/components/EntityPicker/EntityBubble.vue to conditionally pass the user prop to NcUserBubble only for ShareType.User entities
    • Federated users triggered 404 errors when the component attempted to load avatars from non-existent local paths
    • For non-user share types (federated users, groups, emails), the user prop is set to undefined, causing NcUserBubble to display initials from displayName instead of fetching an avatar
    • This approach was inspired by how it's done on apps/files_sharing/src/components/SharingInput.vue for handling different share types in the Files app external sharing feature

Before

before.webm

After

after.webm

Note

When testing locally, the federated search functionality works correctly (remote users appear in search results). However, when attempting to actually add the remote member to a team, an error occurs indicating the remote instance is unreachable. I believe this is expected behavior when running locally, as a similar error occurs when trying to add an external share in the Files app using the same remote account, which is the reference implementation mentioned in the issue and was not modified in this PR.

Checklist

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/EntityPicker/EntityBubble.vue 0.00% 9 Missing ⚠️
src/components/EntityPicker/EntitySearchResult.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

…embers

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the feat/2303/contacts-allow-federated-team-member-search branch from 6a0a354 to 96d743d Compare January 24, 2026 12:41
@hamza221 hamza221 added the enhancement New feature or request label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants