Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
SebastianKrupinski
approved these changes
Feb 8, 2026
Contributor
Author
|
Contributor
Author
|
GVodyanov
force-pushed
the
fix/label-accessibility
branch
2 times, most recently
from
7fcdb0d to
3827d8a
Compare
GVodyanov
force-pushed
the
fix/label-accessibility
branch
from
3827d8a to
c94879f
Compare
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com> # Conflicts: # src/components/Properties/PropertyMultipleText.vue # Conflicts: # src/components/Properties/PropertyText.vue
GVodyanov
force-pushed
the
fix/label-accessibility
branch
from
c94879f to
f5a66f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5048
Final result:
Changes:
ptags for textNcInputFieldwith native label, alignedNcSelectGetting
NcSelectto be the same height and aligned with the input field took some nasty custom CSS seeing as one is 34px and the other 30px, but I'm hoping this will eventually be fixed by nextcloud vue