feat(teams): add confirmation popup when enabling federation for a team#5109
Merged
cristianscheid merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
ArtificialOwl
approved these changes
Feb 16, 2026
cristianscheid
deleted the
feat/2341/team-federation-confirmation-popup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a "simpler" alternative to these two:
Instead of calling an endpoint to remove a team from all parent teams when enabling federation, this PR simply adds a confirmation modal when the user attempts to enable federation.
The contacts PR (#5103) also included a confirmation modal, but additionally called the endpoint created in the circles PR (#2352). This PR only implements the modal without the endpoint call.