fix: retry on httpx exceptions in embedding requests#168
Merged
Conversation
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a retry mechanism for embedding requests by catching specific httpx exceptions and non-200 HTTP responses, adding robustness to network calls.
- Added retry logic with a default of 3 attempts for embedding requests
- Implemented a sleep delay of 5 seconds between retries
- Replaced the generic exception handler with more granular exception handling
Comments suppressed due to low confidence (1)
context_chat_backend/network_em.py:40
- [nitpick] The parameter name 'try_' might be unclear; consider renaming it to 'retries' or 'attempts_left' for better clarity.
def _get_embedding(self, input_: str | list[str], try_: int = 3) -> list[float] | list[list[float]]:
This was referenced Apr 1, 2025
Merged
kyteinsky
added a commit
that referenced
this pull request
Apr 1, 2025
## 4.1.1 - 2025-04-02 ### Fixed - do not fail access update requests if source is not found in db (#163) @kyteinsky - fix for when too many sources/chunks for postgres IN (#166) @lukasdotcom - retry on httpx exceptions in embedding requests (#168) @kyteinsky Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.