Skip to content

chore: improve integration test#170

Merged
kyteinsky merged 4 commits into
masterfrom
improve-int-test
Apr 1, 2025
Merged

chore: improve integration test#170
kyteinsky merged 4 commits into
masterfrom
improve-int-test

Conversation

@kyteinsky
Copy link
Copy Markdown
Contributor

No description provided.

@kyteinsky kyteinsky requested review from Copilot and marcelklehr April 1, 2025 01:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refines the integration test workflow by updating trigger conditions, enhancing the path filter job, and adding a summary job for improved status reporting.

  • Updated pull request and push triggers to use branch filtering
  • Added a "changes" job to detect modified files and conditionally run subsequent jobs
  • Introduced a "summary" job to enforce overall integration test status
Comments suppressed due to low confidence (3)

.github/workflows/integration-test.yml:8

  • [nitpick] The branch 'master' is used as a trigger; if your repository default is 'main', please verify that this selection is intentional.
branches:
      - master

.github/workflows/integration-test.yml:218

  • [nitpick] The grep condition is highly specific to a hardcoded message, which might fail if the output message format changes. Consider using a more flexible check or extracting the expected pattern to a variable.
./occ context_chat:prompt admin "Which factors are taken into account for the Ethical AI Rating?" | grep -q "If all of these points are met, we give a Green label." || exit 1

.github/workflows/integration-test.yml:274

  • The shell conditional in the summary step does not follow standard bash syntax; consider updating it to use proper test expressions (e.g., using [ ... ] or [[ ... ]]) for reliable evaluation.
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration.result != 'success' }}; then exit 1; fi

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Comment thread .github/workflows/integration-test.yml Outdated
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@kyteinsky kyteinsky enabled auto-merge April 1, 2025 14:48
@kyteinsky kyteinsky merged commit 82a5b43 into master Apr 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants