Keywords not handled consistently

[dmbreakey]

When creating a recipe, the UI clearly indicates that the list of keywords are "comma-separated". However, when actually entering keywords, they are clearly parsed based on whitespace (at least, spaces) and commas, instead of just commas.

This makes using keywords like "Instant Pot" impossible, as it is parsed into "instant" and "pot".

I feel that keyword processing should be minimal: break up the list on commas, then trim excess whitespace (trim leading and trailing whitespace and maybe also collapse whitespace inside the tag to just one space). As for normalizing to lower-case, I have no opinion, but I imagine it's more useful than not, assuming it isn't required by the schema?

Or are there plans to integrate into NextCloud's native tagging mechanism? Is that even possible given the Schema.org framework?

[mrzapp]

@dmbreakey if it provides some value, I don't see why we wouldn't parse the tags in the JSON and apply them as NextCloud tags, but seeing as the recipes are only viewed through the Cookbook app, I have a hard time envisioning the use case.

But being unable to use spaces in keywords is clearly a bug, I'll make sure it goes in the pipeline for v0.5.3. Your suggestion for the implementation is also very sensible.

[mrzapp]

Actually, @dmbreakey, would you be interested in contributing this change yourself, or should I handle it? The relevant code is here, if you're interested.

[dmbreakey]

Happy to do it but not familiar with actually using Git (beyond checking out code); do you want me to just paste the diff into this thread, then?

[dmbreakey]

Tested on my local install and it seems to work beautifully.

[theonlytruth]

My opinion about lower case keywords is the following: For Germans it looks very ugly if you have a list of keywords or categories and the are all written lower case. So if there are no technical problems with upper case keyword please make them possible.

[mrzapp]

@theonlytruth agreed, let's keep uppercase

[dmbreakey]

OK, already adjusted my local copy; how do I push it up?

[mrzapp]

@dmbreakey Sorry, I missed that last message of yours. I've done some work on this task too, but I'd like to see what you came up with :) Just do a pull request

[dmbreakey]

OK; I'll try and do that tonight. I went a bit further than you did, and I think it will satisfactorily handle some corner cases that could otherwise be missed, although I'm not sure if these details are being handled elsewhere before they get here.

[dmbreakey]

Not sure I'm doing this correctly; attempted to follow the instructions here, to create a new branch, and the push the edits to that branch but get a "Denied" response when I try to push it. Am I doing something incorrectly?

[mrzapp]

@dmbreakey I'm just guessing here, but that might be because you're trying to push to this repo directly. Step 1 is to create your own fork of this repo, which you might have overlooked.

[dmbreakey]

OK, that makes sense; so how do I do that? I looked for a "fork" option on the UI and I couldn't find it, so I tried to proceed without it.

I do have it cloned down to my PC, but I don't know if that counts as a fork; I'm guessing not.