Upcoming cards logic seems to rely on UTC time instead of adjusting for timezone

[Fufs]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Describe the bug
It's currently just past 10am EST, the card is due at 8pm today (relative time was calculated correctly), however, the card is shown as scheduled for tomorrow. Furthermore, in Tasks, the same card is reporting as due for it's UTC equivalent (Tomorrow 1am).

Client timezone: EST
VM timezone: UTC/EST (same behaviour with either)
Environmental variable: EST

To Reproduce
Steps to reproduce the behavior:

1. Change timezone to something other than UTC
2. Create a card that is due today in local time but tomorrow in UTC
3. Open "Upcoming cards" page
4. The card is listed as due tomorrow

Expected behavior
The card is listed as due today

Screenshots

Client details:

• OS: Windows 10
• Browser: Chrome
• Version: Deck 1.11.3
• Device: Desktop PC

Server details

Operating system: Ubuntu Server 22.04 LTS (Using the official Docker images)
Web server: Nextcloud Apache

Database: PostgreSQL 15.5 on x86_64-pc-linux-musl, compiled by gcc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924, 64-bit

PHP version: 8.1.25

Nextcloud version: 27.1.4

Where did you install Nextcloud from: Docker Hub

Signing status:

List of activated apps:

Nextcloud configuration:

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Logs

Nextcloud log (data/nextcloud.log)

Browser log

[Fufs]

The cards in the overview view are sorted into columns here

deck/lib/Service/OverviewService.php

Lines 88 to 106 in bfe2a90

	foreach ($foundCards as $card) {
	$diffDays = $card->getDaysUntilDue();
	$key = 'later';
	if ($diffDays === null) {
	$key = 'nodue';
	} elseif ($diffDays < 0) {
	$key = 'overdue';
	} elseif ($diffDays === 0) {
	$key = 'today';
	} elseif ($diffDays === 1) {
	$key = 'tomorrow';
	} elseif ($diffDays <= 7) {
	$key = 'nextSevenDays';
	}
	$card = (new CardDetails($card, $card->getRelatedBoard()));
	$overview[$key][] = $card->jsonSerialize();
	}

$diffDays is determined by this function

deck/lib/Db/Card.php

Lines 173 to 186 in bfe2a90

	public function getDaysUntilDue(): ?int {
	if ($this->getDuedate() === null) {
	return null;
	}
	$today = new DateTime();
	$today->setTime(0, 0);
	$matchDate = DateTime::createFromInterface($this->getDuedate());
	$matchDate->setTime(0, 0);
	$diff = $today->diff($matchDate);
	return (int) $diff->format('%R%a'); // Extract days count in interval
	}

the $duedate is at UTC, therefore it's not possible to reliably check if it's due the current day.
A way to fix this is either by offsetting the duedate by the server timezone or by moving the calculation to the frontend. Moving it to the fronted will better reflect the actual meaning of "days until due" as users in a different timezone don't use the timezone the server is in but rather their local time.

[PeteKersker]

This caught my attention as I started using this to manage my smaller projects. Is there any movement on this?

[grnd-alt]

Hey, I've been able to reproduce the issue, thanks a lot for your report. I think we should develop a fix by sorting the issues into the columns on the frontend, by the browsers local time. I'd recommend sending tickets that have a due date in the time range in a simple array on the backend and then sort it on the FE. If one of you is available and wants to come up with a contribution, we'd happily assist you in the process!