Conversation
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
nimishavijay
left a comment
nimishavijay
left a comment
There was a problem hiding this comment.
That's for sure a great change. It should have been "Mark as done" anyway :)
juliusknorr
deleted the
Jerome-Herbinet-completed-card-button-wording-change
branch
|
/backport to stable29 |
|
/backport to stable28 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/5850/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 14daff27
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5850/stable29Error: Failed to clone repository: Failed to checkout branches: Updating 7c756f5..abca471
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/5850/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 14daff27
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5850/stable28Error: Failed to clone repository: Failed to checkout branches: Updating 7c756f5..abca471
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
@juliushaertl do you confirm problems with backports ? |
Refs: nextcloud/deck#5850 Signed-off-by: Stefan Niedermann <info@niedermann.it>
|
/backport to stable29 |
|
/backport to stable28 |
3 participants
My colleagues and I have been using Deck every day, several times a day, for years.
Several of my colleagues and I regularly click on the “Completed” button by mistake (or are tempted to click on it) ... as if to save the changes made to the map (perhaps because “Completed” sounds in their heads like “Fieds are completed”.
I can't say whether this is a problem of button placement or design, but it's certainly a problem of user experience here.
The easiest way to avoid this is to change the label from “Completed” to “Mark as done”.
Below is the wording that I would like to change thanks to this PR, if I am not mistaken (I also changed the reverse action wording - check the commit):
Checklist