Extend due date options for better scheduling flexibility #6817
Conversation
* Added options to select either next month or next quarter to accommodate long-term planning needs. Signed-off-by: Glenn <glenux@glenux.net>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
| const nextMonthTime = moment().add(1, 'months').day(1).hour(8) | ||
| // Next Quarter 1set 08:00 AM | ||
| const nextQuarterTime = moment().add(3, 'months').day(1).hour(8) |
There was a problem hiding this comment.
In line 182 and 184: the .day(1) will select the Monday but not the first date in month. It doesn't seem to match the comment.
| { | ||
| key: 'nextMonth', | ||
| timestamp: this.getTimestamp(nextMonthTime), | ||
| label: t('deck', 'Next month – {timeLocale}', { timeLocale: nextMonthTime?.format('ddd LT') }), |
There was a problem hiding this comment.
Since the target due date might be far from the current date, I think the format should be adjusted to show the year, month, and day as well.
| { | ||
| key: 'nextQuarter', | ||
| timestamp: this.getTimestamp(nextQuarterTime), | ||
| label: t('deck', 'Next quarter – {timeLocale}', { timeLocale: nextQuarterTime?.format('ddd LT') }), |
There was a problem hiding this comment.
Since the target due date might be far from the current date, I think the format should be adjusted to show the year, month, and day as well.
|
@glenux Thanks for your PR! I've left a few comments. |
2 participants
Summary
Added options to select either next month or next quarter to accommodate long-term planning needs.
TODO
Checklist