Skip to content

Conversation

@theoholl
Copy link
Contributor

@theoholl theoholl commented Dec 7, 2025

Summary

  • Extend BaseValidator class to allow the string value "0" as the board title.
  • Add unit test for the BoardService.
  • Update test function in BoardMapperTest to be more robust against database changes introduced from outside the test.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Theo Hollweg <thollweg@mailbox.org>
…ated

Signed-off-by: Theo Hollweg <thollweg@mailbox.org>
@luka-nextcloud luka-nextcloud force-pushed the update-validator-to-allow-0-board-name branch from bfbc0a7 to d0e1a4e Compare December 18, 2025 17:33
@luka-nextcloud luka-nextcloud merged commit a03946c into nextcloud:main Dec 18, 2025
32 of 36 checks passed
@theoholl theoholl deleted the update-validator-to-allow-0-board-name branch December 18, 2025 19:45
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't create Board with title 0

2 participants