fix: improve gantt rendering#8013
Merged
Merged
Conversation
Signed-off-by: grnd-alt <git@belakkaf.net>
grnd-alt
force-pushed
the
fix/improve-gantt-rendering
branch
from
862b221 to
f0457fd
Compare
blizzz
approved these changes
Jun 4, 2026
Comment on lines
+213
to
+214
| switch (this.currentViewMode) { | ||
| case 'Hour': |
Member
There was a problem hiding this comment.
💄 indentation looks odd on Github (tabs vs spaces?)
Member
Author
There was a problem hiding this comment.
apparently, the lint:fix wants case and switch on the same column...
| const duedate = new Date(card.duedate) | ||
| switch (this.currentViewMode) { | ||
| case 'Hour': | ||
| if (duedate < new Date() - 2 * 24 * 3600 * 1000) { |
Member
There was a problem hiding this comment.
so cards from the past are cut off, right?
Member
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is mainly a workaround to make the gantt chart usable for bigger boards, we should put some effort into this issue upstream frappe/gantt#486