fix: loading notifications#8126
Open
luka-nextcloud wants to merge 1 commit into
Open
Conversation
Signed-off-by: Luka Trovic <luka@nextcloud.com>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
luka-nextcloud
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exception handling improvements:
canSeeCardActivityto catch bothNoPermissionExceptionandDoesNotExistException, ensuring it returnsfalseif the card doesn't exist or the user lacks permission.canSeeBoardActivityto also catch bothNoPermissionExceptionandDoesNotExistException, so it returnsfalseif the board doesn't exist or the user lacks permission.Checklist