Skip to content

fix: double background in settings navigation#10046

Merged
Rello merged 3 commits into
masterfrom
bugfix/navigationBackground
May 19, 2026
Merged

fix: double background in settings navigation#10046
Rello merged 3 commits into
masterfrom
bugfix/navigationBackground

Conversation

@Rello
Copy link
Copy Markdown
Collaborator

@Rello Rello commented May 18, 2026

fix the darker background in the inner nav container
Bildschirmfoto 2026-05-18 um 21 02 30

@Rello Rello self-assigned this May 18, 2026
@nilsding
Copy link
Copy Markdown
Member

looks better on Windows now:

Dark mode Light mode
Screenshot of the account settings with correct background colours on Windows 11 in dark mode Screenshot of the account settings with correct background colours on Windows 11 in light mode

@nilsding nilsding added this to the 33.0.5 milestone May 19, 2026
Rello and others added 3 commits May 19, 2026 10:31
Signed-off-by: Rello <Rello@users.noreply.github.com>
Disable background filling and set styles for folder list.

Signed-off-by: Rello <Rello@users.noreply.github.com>
also gets rid of some stylesheets that caused more troubles than they solved

part of #9824

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding force-pushed the bugfix/navigationBackground branch from eeb3ccf to 15e237a Compare May 19, 2026 08:31
@github-actions
Copy link
Copy Markdown

Artifact containing the AppImage: nextcloud-appimage-pr-10046.zip

Digest: sha256:27024b9ab17ad19809d8a5208ce22bc692ea5934ab7f0736376ab332d4eeaf9d

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Rello
Copy link
Copy Markdown
Collaborator Author

Rello commented May 19, 2026

Bildschirmfoto 2026-05-19 um 11 36 07

still ok on macos

@Rello Rello marked this pull request as ready for review May 19, 2026 09:36
@Rello Rello requested review from camilasan, i2h3 and mgallien as code owners May 19, 2026 09:36
@Rello Rello merged commit e5a2939 into master May 19, 2026
23 checks passed
@Rello Rello deleted the bugfix/navigationBackground branch May 19, 2026 09:36
@Rello
Copy link
Copy Markdown
Collaborator Author

Rello commented May 19, 2026

/backport to stable-33.0

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
52 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] New UI of settings is annoying and hard to read

2 participants