[stable-34.0] Prevent crash on wake (Ticket#96101255)#10294
Merged
Conversation
The tray window loads avatars and file previews over the network. When the Mac wakes from sleep, the client resets the account's network manager, which threw away the in-flight image download. The image-loading thread then tried to read that already-deleted download and crashed. Keep the network manager alive until the image request finishes, and clean up the download afterwards, so nothing is read after it's gone. Fixes the SIGSEGV in AsyncImageResponse::processNetworkReply reported on 33.0.7 (crash ~5s after wake from sleep). Signed-off-by: Iva Horn <iva.horn@nextcloud.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
backportbot
Bot
requested review from
camilasan,
mgallien and
nilsding
as code owners
backportbot
Bot
added
bug
os: 🍎 macOS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10290