Skip to content

Conversation

@sbeyer
Copy link
Member

@sbeyer sbeyer commented Jun 6, 2020

The app menu has a width based on the header button size which is
way too narrow to display its content, see #2012.

This PR changes the width based on the contents (menu items) of
the menu, however, limiting the maximum width to half the window width.

@jancborchardt
Copy link
Member

This PR changes the width based on the contents (menu items) of
the menu, however, limiting the maximum width to half the window width.

By "window width", do you mean "screen width"? If so I’d say the prospect of a tray menu half the screen width is a bit much. Don’t we have some max value for the height? I’d say that should be the maximum for the width, so it never goes "landscape mode".

@sbeyer
Copy link
Member Author

sbeyer commented Jun 7, 2020

By "window width", do you mean "screen width"?

No, let two screenshots speak for themselves:

  • The new apps menu with a width based on its content:
    new apps menu
  • The new apps menu with maximum width of half the window width; fake showcase in which we have very long app names (for this screenshot we have added the string " including a long fake suffix")
    new apps menu with maximum width

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, misinterpreted "app menu" as "menu of the app" not as "the menu with the app list". ;)

Looks great now, thanks a lot for the screenshots – awesome work! :)

@sbeyer
Copy link
Member Author

sbeyer commented Jun 7, 2020

Sorry, misinterpreted "app menu" as "menu of the app" not as "the menu with the app list". ;)

Ah, now your original comment makes more sense to me. I think I call that the "tray window", or is the "menu of the app" yet another menu? 😄

@jancborchardt
Copy link
Member

Yep, of course you're right, "tray window" is the word for that. I think a contributing factor to my confusion was that it was around 3 AM in the night. ;)

The app menu had a width based on the header button size which was
way too narrow to display its content.

This commit changes the width based on the contents (menu items) of
the menu, however, limiting the maximum width to half the window width.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
@sbeyer sbeyer force-pushed the sbeyer-fix-app-menu-width branch from c64b4db to a0ad483 Compare June 8, 2020 21:38
@er-vin er-vin merged commit 2946c33 into master Jun 9, 2020
@er-vin er-vin deleted the sbeyer-fix-app-menu-width branch June 9, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: ☁️ GUI System tray icon and menu.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants