Web view Fix for Self Signed Certificates #630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for **self signed certificates**.
camilasan
requested changes
Sep 7, 2018
src/gui/wizard/webview.cpp
Outdated
|
|
||
| bool WebEnginePage::certificateError(const QWebEngineCertificateError &certificateError) { | ||
| //handle webview certificate errors here | ||
| return true; |
Member
There was a problem hiding this comment.
This means we just accept all self signed certificates right?
Author
There was a problem hiding this comment.
certificates are already accepted or rejected at the setup page.
indentation fixed.
|
If the WebView does not have certificates (in the setup wizard). This will probably not help. |
rullzer
reviewed
Sep 7, 2018
|
|
||
| bool WebEnginePage::certificateError(const QWebEngineCertificateError &certificateError) { | ||
| //handle webview certificate errors here | ||
| return true; |
Member
There was a problem hiding this comment.
Ok so after looking it up. really fixing it is not so straight forward as the webengineview uses it own network stack. So no QNAM etc.
What we could do. Is pass in the original URL we try to connect to. As we have to accept that cert before continuing.
If the url matches the cert here. Then we continue. Else we should still fail.
How does that sound?
Member
|
See #758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for self signed certificates.