Skip to content

fix: initialize user list when the first acc is added#9156

Merged
nilsding merged 1 commit intonextcloud:masterfrom
DmySyz:initialize-usermodel-when-first-acc-is-added
Dec 1, 2025
Merged

fix: initialize user list when the first acc is added#9156
nilsding merged 1 commit intonextcloud:masterfrom
DmySyz:initialize-usermodel-when-first-acc-is-added

Conversation

@DmySyz
Copy link
Contributor

@DmySyz DmySyz commented Dec 1, 2025

Missed one place where the accountListInitialized signal should be emitted in #9061.

Sorry for the inconvenience.

@DmySyz DmySyz force-pushed the initialize-usermodel-when-first-acc-is-added branch from 3d4251f to 6cae344 Compare December 1, 2025 08:50
@nilsding nilsding force-pushed the initialize-usermodel-when-first-acc-is-added branch from 6cae344 to 4ba2125 Compare December 1, 2025 15:01
@nilsding nilsding enabled auto-merge December 1, 2025 15:01
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just ran into this while testing, and this PR resolved the issue. thanks!

Modified account manager to emit accountListInitialized signal when the
first account is added

Signed-off-by: dsyzov <sizovdmitrij@gmail.com>
@nilsding nilsding force-pushed the initialize-usermodel-when-first-acc-is-added branch from 4ba2125 to fb5ff0c Compare December 1, 2025 16:22
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9156.zip

Digest: sha256:67c76055090b5e4749cb2b03c907771f47322acdac7ebbe6dbc3dc305dee49e1

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding merged commit 1f7ab3c into nextcloud:master Dec 1, 2025
18 of 19 checks passed
@DmySyz DmySyz deleted the initialize-usermodel-when-first-acc-is-added branch December 1, 2025 17:34
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments