[stable-3.17] refactor: Use correct string overload#9230
Merged
camilasan merged 1 commit intostable-3.17from Dec 11, 2025
Merged
[stable-3.17] refactor: Use correct string overload#9230camilasan merged 1 commit intostable-3.17from
camilasan merged 1 commit intostable-3.17from
Conversation
Use QLatin1String overload when possible (mostly QJsonObject and string comparaison). See https://www.volkerkrause.eu/2023/09/09/qt-string-bloat.html Save around 11Kib in the final binary. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
camilasan
force-pushed
the
backport/8992/stable-3.17
branch
from
5278f55 to
c9ba287
Compare
Member
|
Not really sure this need a backport, this is a tiny optimization reducing a bit the binary size and removing some allocation |
camilasan
approved these changes
Dec 11, 2025
|
Artifact containing the AppImage: nextcloud-appimage-pr-9230.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8992
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.