Skip to content

fix(debugArchive): ensure proper path for destination file name#9311

Merged
mgallien merged 1 commit intomasterfrom
bugfix/fixDebugArchiveGenerationOnWindows
Jan 21, 2026
Merged

fix(debugArchive): ensure proper path for destination file name#9311
mgallien merged 1 commit intomasterfrom
bugfix/fixDebugArchiveGenerationOnWindows

Conversation

@mgallien
Copy link
Collaborator

@mgallien mgallien commented Jan 13, 2026

on windows, it is necessary to convert the URL for the destination target for debug archive to a proper local file

hopefully does not break macOS

@mgallien mgallien added this to the 4.1.0 milestone Jan 13, 2026
@mgallien
Copy link
Collaborator Author

mgallien commented Jan 13, 2026

does not affect stable branch

@mgallien mgallien force-pushed the bugfix/fixDebugArchiveGenerationOnWindows branch from 5a45eff to a3c918c Compare January 21, 2026 11:31
@mgallien mgallien enabled auto-merge January 21, 2026 11:31
@i2h3
Copy link
Collaborator

i2h3 commented Jan 21, 2026

Let me check on macOS first…

@mgallien @i2h3
fix(debugArchive): ensure proper path for destination file name
fbc455b 
on windows, it is necessary to convert the URL for the destination
target for debug archive to a proper local file

hopefully does not break macOS

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@i2h3 i2h3 force-pushed the bugfix/fixDebugArchiveGenerationOnWindows branch from a3c918c to fbc455b Compare January 21, 2026 13:15
@i2h3
Copy link
Collaborator

i2h3 commented Jan 21, 2026

I rebased it on current master.

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9311.zip

Digest: sha256:270e7934b46ebe101940bac4e1999b1f1c9a875242de4552ca2fc291952c357e

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
21 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 7d0bd8f into master Jan 21, 2026
23 of 24 checks passed
@mgallien mgallien deleted the bugfix/fixDebugArchiveGenerationOnWindows branch January 21, 2026 14:13
i2h3
i2h3 reviewed Jan 21, 2026
View reviewed changes
Copy link
Collaborator

@i2h3 i2h3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it continues to work fine on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i2h3 i2h3 i2h3 left review comments

@nilsding nilsding nilsding approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

33.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mgallien @i2h3 @nilsding

Comments