feat: Nextcloud Assistant integration by Rello · Pull Request #9431 · nextcloud/desktop

Rello · 2026-02-06T10:09:06Z

No description provided.

Rello · 2026-02-10T13:17:01Z

nilsding

Some comments -- the Talk cleanup and potential refactoring can be done in a follow-up PR.

nilsding · 2026-02-17T10:22:28Z

src/gui/networksettings.cpp

this change seems unrelated to this PR

nilsding · 2026-02-17T10:26:59Z

src/gui/tray/MainWindow.qml

-                trayWindowHeader.currentAccountHeaderButton.accountMenu.close();
-                trayWindowHeader.appsMenu.close();
-                trayWindowHeader.openLocalFolderButton.closeMenu()
-                UserModel.refreshSyncErrorUsers()


this is missing in the updated version

nilsding · 2026-02-17T10:30:03Z

src/gui/tray/MainWindow.qml

-                                             || trayWindowUnifiedSearchInputContainer.activateSearchFocus
-
-        anchors.fill: parent
-        anchors.margins: Style.trayWindowBorderWidth


this is missing in the updated version, not sure if it was intentional that this got removed

nilsding · 2026-02-17T10:39:29Z

src/gui/tray/usermodel.cpp


 bool User::isFeaturedAppEnabled() const
 {
-    return isNcAssistantEnabled() || serverHasTalk();


so the Talk button is no more, even if assistant is disabled?

in that case we should clean up references to that as well (remove talk-app.svg and other methods in here since they're no longer used)

nilsding · 2026-02-17T10:44:43Z

src/gui/tray/MainWindow.qml

-            anchors.top: trayWindowSyncWarning.visible
-                         ? trayWindowSyncWarning.bottom
-                         : trayWindowHeader.bottom


this is missing in the updated version

nilsding · 2026-02-17T10:47:35Z

src/gui/tray/MainWindow.qml

would rather move these to a separate component outside of MainWindow for better maintainability where possible

100% agree. Good next step

nilsding · 2026-02-17T11:04:19Z

src/gui/tray/usermodel.cpp

+            const auto textValue = nestedObject.value("text"_L1);
+            if (textValue.isString()) {
+                return textValue.toString();
+            }
+            const auto answerValue = nestedObject.value("answer"_L1);
+            if (answerValue.isString()) {
+                return answerValue.toString();
+            }
+        }
+
+        const auto textValue = outputObject.value("text"_L1);
+        if (textValue.isString()) {
+            return textValue.toString();
+        }
+        const auto answerValue = outputObject.value("answer"_L1);
+        if (answerValue.isString()) {
+            return answerValue.toString();
+        }


Suggested change

const auto textValue = nestedObject.value("text"_L1);

if (textValue.isString()) {

return textValue.toString();

}

const auto answerValue = nestedObject.value("answer"_L1);

if (answerValue.isString()) {

return answerValue.toString();

}

}

const auto textValue = outputObject.value("text"_L1);

if (textValue.isString()) {

return textValue.toString();

}

const auto answerValue = outputObject.value("answer"_L1);

if (answerValue.isString()) {

return answerValue.toString();

}

if (const auto textValue = nestedObject.value("text"_L1); textValue.isString()) {

return textValue.toString();

}

if (const auto answerValue = nestedObject.value("answer"_L1); answerValue.isString()) {

return answerValue.toString();

}

}

if (const auto textValue = outputObject.value("text"_L1); textValue.isString()) {

return textValue.toString();

}

if (const auto answerValue = outputObject.value("answer"_L1); answerValue.isString()) {

return answerValue.toString();

}

nilsding · 2026-02-17T11:11:08Z

src/gui/tray/usermodel.h

+    Q_INVOKABLE void submitAssistantQuestion(const QString &question);
+    Q_INVOKABLE void clearAssistantResponse();


These could be moved to public slots:, that way there's no need for Q_INVOKABLE

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

known issue is that we forget to wait long enough for the reply we also probably would fail to handle more than one request in parallel so we should prevent submitting more than one at a time Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>