Conversation
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
i2h3
force-pushed
the
i2h3/fix/libvpx-not-found
branch
from
cc4218f to
1c2a117
Compare
i2h3
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the macOS bundle deployment step so macdeployqt is given an explicit Qt library search path, improving its ability to locate and bundle dependencies like libvpx.
Changes:
- Derive the
macdeployqtinstallation directory and an associated../libdirectory. - Pass the derived library directory to
macdeployqtvia-libpath=...during the post-build bundle step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/backport to stable-33.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9497.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Added two lines after find_program(MACDEPLOYQT_EXECUTABLE ...) to compute the lib directory adjacent to the macdeployqt binary (i.e., ../lib relative to its bin/ directory), then passed it as -libpath to the macdeployqt invocation. Root cause of the libvpx error: The craft-built libvpx.11.dylib has a bare install name (libvpx.11.dylib, no @rpath/ prefix). When macdeployqt encounters it as a dependency of ffmpeg/libavcodec and tries to locate the file, it falls back to searching /usr/lib/ — where it doesn't exist. The -libpath option adds the craft lib/ directory to macdeployqt's search path, so it finds the library at .mac-crafter/macos-clang-arm64/lib/libvpx.11.dylib. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
i2h3/fix/libvpx-not-found
branch
from
1c2a117 to
b5914af
Compare
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
|
Finally get rid of that not critical build error on macOS: