fix(macOS): Defined PRODUCT_BUNDLE_IDENTIFIER for FinderSync#9498
fix(macOS): Defined PRODUCT_BUNDLE_IDENTIFIER for FinderSync#9498
Conversation
The FinderSync extension target was missing the PRODUCT_BUNDLE_IDENTIFIER build setting which resulted in compiler warnings in Xcode. That build setting is defined like for the other extensions. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
|
/backport to stable-33.0 |
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing PRODUCT_BUNDLE_IDENTIFIER build setting for the FinderSync extension target in the Xcode project, which was causing compiler warnings. The fix adds the setting to both Debug and Release build configurations using the same pattern found in the extension's Info.plist file.
Changes:
- Added PRODUCT_BUNDLE_IDENTIFIER build setting to FinderSyncExt Debug configuration
- Added PRODUCT_BUNDLE_IDENTIFIER build setting to FinderSyncExt Release configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Artifact containing the AppImage: nextcloud-appimage-pr-9498.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
The FinderSync extension target was missing the PRODUCT_BUNDLE_IDENTIFIER build setting which resulted in compiler warnings in Xcode. That build setting is defined like for the other extensions.