Skip to content

chore(macOS): Updated Xcode Project Settings#9499

Merged
i2h3 merged 1 commit intomasterfrom
i2h3/chore/updated-xcode-project
Feb 24, 2026
Merged

chore(macOS): Updated Xcode Project Settings#9499
i2h3 merged 1 commit intomasterfrom
i2h3/chore/updated-xcode-project

Conversation

@i2h3
Copy link
Collaborator

@i2h3 i2h3 commented Feb 24, 2026

Every now and then new Xcode releases suggest updates and optimizations to projects and its settings. These apparently have been overdue since a long time now.

@i2h3 i2h3 added this to the 33.0.0 milestone Feb 24, 2026
@i2h3 i2h3 self-assigned this Feb 24, 2026
Copilot AI review requested due to automatic review settings February 24, 2026 10:00
@i2h3 i2h3 added the os: 🍎 macOS Apple macOS, formerly also known as OS X label Feb 24, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Feb 24, 2026
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Feb 24, 2026
Based on the suggestions of the latest Xcode, the project settings have been updated.

- Build phase "Embed App Extensions" was renamed to "Embed Foundation Extensions"
- ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES has been removed
- DEAD_CODE_STRIPPING was enabled in general
- ENABLE_MODULE_VERIFIER has been turned on
- ONLY_ACTIVE_ARCH for debug configurations

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/chore/updated-xcode-project branch from 94bd199 to 198448f Compare February 24, 2026 10:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the macOS Xcode project settings for the Nextcloud desktop client's shell integration. The changes reflect an upgrade to a newer version of Xcode (from 12.4.0 to a much higher version), applying modern Xcode build settings and best practices. The update includes standardizing bundle identifier handling, enabling new compiler features, and renaming build phases to match current Xcode conventions.

Changes:

  • Standardized bundle identifier handling by replacing hardcoded values with $(PRODUCT_BUNDLE_IDENTIFIER) variable
  • Updated Xcode project to version 26.2.0 with modern build settings including dead code stripping, module verification, and localization analysis
  • Renamed "Embed App Extensions" to "Embed Foundation Extensions" following newer Xcode conventions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
shell_integration/MacOSX/NextcloudIntegration/desktopclient/Info.plist Changed CFBundleIdentifier from hardcoded value to use $(PRODUCT_BUNDLE_IDENTIFIER) variable
shell_integration/MacOSX/NextcloudIntegration/NextcloudIntegration.xcodeproj/project.pbxproj Updated Xcode project version, added modern build settings (DEAD_CODE_STRIPPING, ENABLE_MODULE_VERIFIER, etc.), renamed embed phase, removed deprecated ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES setting, and added PRODUCT_BUNDLE_IDENTIFIER to build configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9499.zip

Digest: sha256:5a9bb6e06f3c7897c8e79cb7b12e447eb1ef37a0ecc772bf5f75d8b4f42080da

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

@i2h3
Copy link
Collaborator Author

i2h3 commented Feb 24, 2026

/backport to stable-33.0

@i2h3 i2h3 merged commit 997bdf0 into master Feb 24, 2026
24 checks passed
@i2h3 i2h3 deleted the i2h3/chore/updated-xcode-project branch February 24, 2026 11:28
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants