[stable-33.0] fix(macOS): Resolved Some Xcode Compiler Warnings#9507
Merged
i2h3 merged 2 commits intostable-33.0from Feb 24, 2026
Merged
[stable-33.0] fix(macOS): Resolved Some Xcode Compiler Warnings#9507i2h3 merged 2 commits intostable-33.0from
i2h3 merged 2 commits intostable-33.0from
Conversation
backportbot
bot
requested review from
i2h3,
mgallien and
nilsding
as code owners
backportbot
bot
added
bug
os: 🍎 macOS
… in dispatch_async blocks - Addressed compiler warnings about “block implicitly retains ‘self’” in FinderSyncSocketLineProcessor.m by explicitly handling self capture in all dispatch_async blocks within the process: method. - For each block that referenced self (STATUS, UPDATE_VIEW, REGISTER_PATH, UNREGISTER_PATH, STRING, GET_MENU_ITEMS BEGIN, and MENU_ITEM), introduced a weak-then-strong self pattern: - Declared __weak typeof(self) weakSelf = self; before the block. - Inside the block, re-established a strong reference with __strong typeof(self) self = weakSelf; and guarded with if (!self) return;. - Updated logging inside blocks to use self->_log to ensure explicit self usage. - Preserved existing logic and behavior for delegate calls and logging while eliminating -Wimplicit-retain-self warnings and reducing risk of retain cycles. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
|
Artifact containing the AppImage: nextcloud-appimage-pr-9507.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9500