[stable-4.0] fix(win32): only increase ACL size if a new ACE is about to be added#9531
Merged
nilsding merged 2 commits intostable-4.0from Feb 26, 2026
Merged
[stable-4.0] fix(win32): only increase ACL size if a new ACE is about to be added#9531nilsding merged 2 commits intostable-4.0from
nilsding merged 2 commits intostable-4.0from
Conversation
backportbot
bot
requested review from
Aiiaiiio,
camilasan and
i2h3
as code owners
Noticed that GetLastError() could return 0 (error code for a successful operation) -- probably due to win32 calls performed during logging --> Store the result in a variable before writing log messages, just in case ... Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Also added some extra logging when InitializeAcl fails, and a regression test. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
|
Artifact containing the AppImage: nextcloud-appimage-pr-9531.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
nilsding
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9491