Skip to content

Bugfix/migrate user encryption certificate#9568

Merged
mgallien merged 5 commits intomasterfrom
bugfix/migrateUserEncryptionCertificate
Mar 10, 2026
Merged

Bugfix/migrate user encryption certificate#9568
mgallien merged 5 commits intomasterfrom
bugfix/migrateUserEncryptionCertificate

Conversation

@mgallien
Copy link
Collaborator

@mgallien mgallien commented Mar 5, 2026

No description provided.

@mgallien mgallien enabled auto-merge March 10, 2026 09:54
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we need updated user certificate before we upload new encryption
metadata to ensure they are generated with the correct certificate and
private key

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
ensure we do store in the metadata file the properly encrypted metadata
key

ensure we would update the user own certificate before eventually
encrypting again the metadata key

do this before we would try to write the metadata file and ensure it is
writtent with updated values instead of getting a copy of the old values
(before the certificate change)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/migrateUserEncryptionCertificate branch from 3057fc0 to 8145189 Compare March 10, 2026 11:56
@mgallien
Copy link
Collaborator Author

/backport to stable-33.0

@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9568.zip

Digest: sha256:f319b726f5e9376e226d03afe828a7ab014c8f13a42935acd99620c379948299

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 121b962 into master Mar 10, 2026
22 checks passed
@mgallien mgallien deleted the bugfix/migrateUserEncryptionCertificate branch March 10, 2026 12:37
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
54.9% Coverage on New Code (required ≥ 80%)
6.1% Duplication on New Code (required ≤ 3%)
E Maintainability Rating on New Code (required ≥ A)
273 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien
Copy link
Collaborator Author

/backport to stable-4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants