Skip to content

fix(filesystem): deal with win32 long paths when recursively removing folders#9634

Merged
nilsding merged 1 commit intomasterfrom
bugfix/9293/win32-longpaths-recursive-deletion
Mar 17, 2026
Merged

fix(filesystem): deal with win32 long paths when recursively removing folders#9634
nilsding merged 1 commit intomasterfrom
bugfix/9293/win32-longpaths-recursive-deletion

Conversation

@nilsding
Copy link
Member

@nilsding nilsding commented Mar 16, 2026

std::filesystem::remove etc. seem to behave the same way as the pure win32-APIs: sometimes long paths work, sometimes they won't. In this case it seems to be able to deal with long UNC-style paths just fine ...

Resolves #9425 (also mentioned in #9293 (comment))

@nilsding
Copy link
Member Author

/backport to stable-33.0

@nilsding
Copy link
Member Author

/backport to stable-4.0

@nilsding nilsding enabled auto-merge March 16, 2026 13:08
… folders

`std::filesystem::remove` etc. seem to behave the same way as the pure
win32-APIs: sometimes long paths work, sometimes they won't.  In this
case it seems to be able to deal with long UNC-style paths just fine ...

Resolves #9293

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding force-pushed the bugfix/9293/win32-longpaths-recursive-deletion branch from eff83ae to fb6dd31 Compare March 17, 2026 07:53
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9634.zip

Digest: sha256:5a50ee34290f3bc1d812e70b09b64a6d8b97d1c1e7869253d49979e2abc93248

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
24 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nilsding nilsding merged commit 3488331 into master Mar 17, 2026
24 of 26 checks passed
@nilsding nilsding deleted the bugfix/9293/win32-longpaths-recursive-deletion branch March 17, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sync Error: Local folders not removed after server-side deletion (Group Folders) on long paths & "Zombie" folder re-uploads

2 participants