Skip to content

fix: remove unused COPY_SECUREFILEDROP_LINK socket command#9808

Merged
mgallien merged 1 commit into
masterfrom
codex/locate-usage-of-command_copy_securefiledrop_link
Apr 8, 2026
Merged

fix: remove unused COPY_SECUREFILEDROP_LINK socket command#9808
mgallien merged 1 commit into
masterfrom
codex/locate-usage-of-command_copy_securefiledrop_link

Conversation

@Rello
Copy link
Copy Markdown
Collaborator

@Rello Rello commented Apr 8, 2026

Motivation

  • Reduce the exposed/unnecessary socket API surface by removing an unsecured socket endpoint that had no producers or call sites in the codebase.

Description

  • Removed COPY_SECUREFILEDROP_LINK from the FinderSync allow-list in src/gui/macOS/findersyncservice.mm so the macOS extension can no longer invoke it.
  • Removed the Q_INVOKABLE declaration for command_COPY_SECUREFILEDROP_LINK from src/gui/socketapi/socketapi.h.
  • Removed the SocketApi::command_COPY_SECUREFILEDROP_LINK implementation from src/gui/socketapi/socketapi.cpp.

Testing

  • Verified there are no remaining references by searching for COPY_SECUREFILEDROP_LINK and command_COPY_SECUREFILEDROP_LINK with rg, which returned no hits after the change (success).
  • Inspected related helpers such as GetOrCreatePublicLinkShare to ensure no dependent behavior was removed (manual code inspection, success).
  • Attempted xcodebuild build -target NextcloudDev as recommended for macOS build verification but the environment lacks xcodebuild, so a full macOS build could not be run here (not executed).

Codex Task

@Rello Rello requested review from Aiiaiiio and camilasan as code owners April 8, 2026 08:08
@Rello Rello requested review from i2h3, mgallien and nilsding as code owners April 8, 2026 08:08
@Rello Rello added this to the 33.0.3 milestone Apr 8, 2026
@Rello Rello self-assigned this Apr 8, 2026
The COPY_SECUREFILEDROP_LINK socket endpoint had no menu producer and no call sites. Remove the endpoint and its macOS FinderSync allow-list entry to reduce socket API surface.

Signed-off-by: Rello <Rello@users.noreply.github.com>
@mgallien mgallien enabled auto-merge April 8, 2026 13:00
@mgallien mgallien force-pushed the codex/locate-usage-of-command_copy_securefiledrop_link branch from 5548428 to 3574314 Compare April 8, 2026 13:00
@mgallien
Copy link
Copy Markdown
Collaborator

mgallien commented Apr 8, 2026

/backport to stable-33.0

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9808.zip

Digest: sha256:986ac613ad1c6e9e9b4aea081b50b83c573ce088faee48eed7ecfb97a0e0d357

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
29 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit a996bb1 into master Apr 8, 2026
22 of 23 checks passed
@mgallien mgallien deleted the codex/locate-usage-of-command_copy_securefiledrop_link branch April 8, 2026 13:42
@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 8, 2026

The backport to stable-33.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-33.0
git pull origin stable-33.0

# Create the new backport branch
git checkout -b backport/9808/stable-33.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3574314d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9808/stable-33.0

Error: Failed to check for changes with origin/stable-33.0: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nilsding
Copy link
Copy Markdown
Member

nilsding commented Apr 8, 2026

/backport to stable-33.0

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 8, 2026

The backport to stable-33.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-33.0
git pull origin stable-33.0

# Create the new backport branch
git checkout -b backport/9808/stable-33.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3574314d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9808/stable-33.0

Error: Failed to check for changes with origin/stable-33.0: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants