fix: remove unused COPY_SECUREFILEDROP_LINK socket command#9808
Conversation
The COPY_SECUREFILEDROP_LINK socket endpoint had no menu producer and no call sites. Remove the endpoint and its macOS FinderSync allow-list entry to reduce socket API surface. Signed-off-by: Rello <Rello@users.noreply.github.com>
5548428 to
3574314
Compare
|
/backport to stable-33.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9808.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
The backport to # Switch to the target branch and update it
git checkout stable-33.0
git pull origin stable-33.0
# Create the new backport branch
git checkout -b backport/9808/stable-33.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3574314d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9808/stable-33.0Error: Failed to check for changes with origin/stable-33.0: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable-33.0 |
|
The backport to # Switch to the target branch and update it
git checkout stable-33.0
git pull origin stable-33.0
# Create the new backport branch
git checkout -b backport/9808/stable-33.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3574314d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9808/stable-33.0Error: Failed to check for changes with origin/stable-33.0: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |




Motivation
Description
COPY_SECUREFILEDROP_LINKfrom the FinderSync allow-list insrc/gui/macOS/findersyncservice.mmso the macOS extension can no longer invoke it.Q_INVOKABLEdeclaration forcommand_COPY_SECUREFILEDROP_LINKfromsrc/gui/socketapi/socketapi.h.SocketApi::command_COPY_SECUREFILEDROP_LINKimplementation fromsrc/gui/socketapi/socketapi.cpp.Testing
COPY_SECUREFILEDROP_LINKandcommand_COPY_SECUREFILEDROP_LINKwithrg, which returned no hits after the change (success).GetOrCreatePublicLinkShareto ensure no dependent behavior was removed (manual code inspection, success).xcodebuild build -target NextcloudDevas recommended for macOS build verification but the environment lacksxcodebuild, so a full macOS build could not be run here (not executed).Codex Task