Skip to content

[stable-4.0] fix(folderman): disconnect slotFolderCanSyncChanged when unloading folder.#9817

Merged
camilasan merged 5 commits intostable-4.0from
backport/9813/stable-4.0
Apr 9, 2026
Merged

[stable-4.0] fix(folderman): disconnect slotFolderCanSyncChanged when unloading folder.#9817
camilasan merged 5 commits intostable-4.0from
backport/9813/stable-4.0

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Apr 9, 2026

Backport of #9813

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

…lder.

In case the account state changes during shutdown, the folder might not exist anymore.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
…Path.

Passing doWait=true caused socket->waitForBytesWritten(1000) to emit a signal.
During shutdown, the signal could trigger slotUnregisterPath,
corrupting _registeredAliases and crashing with EXC_BAD_ACCESS.

Removing doWait eliminates the nested event loop and the re-entrancy.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
@backportbot backportbot Bot requested review from camilasan and nilsding April 9, 2026 09:14
@backportbot backportbot Bot added this to the 4.0.9 milestone Apr 9, 2026
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the backport/9813/stable-4.0 branch from bf7bfd5 to 70782a3 Compare April 9, 2026 09:16
@camilasan camilasan marked this pull request as ready for review April 9, 2026 09:16
@camilasan camilasan merged commit 93721bb into stable-4.0 Apr 9, 2026
15 of 17 checks passed
@camilasan camilasan deleted the backport/9813/stable-4.0 branch April 9, 2026 09:17
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant