[stable-4.0] fix: use openBrowser to open URLs

src/gui/guiutility.cpp

@@ -20,13 +20,19 @@
 
 bool Utility::openBrowser(const QUrl &url, QWidget *errorWidgetParent)
 {
+    if (!url.isValid()) {
+        qCWarning(lcUtility) << "URL format is invalid and has been rejected:" << url.toString();
+        return false;
+    }
+
     const QStringList allowedUrlSchemes = {
         "http",
         "https",
     };
-
-    if (!allowedUrlSchemes.contains(url.scheme())) {
-        qCWarning(lcUtility) << "URL format is not supported, or it has been compromised for:" << url.toString();
+
+    const auto scheme = url.scheme().toLower();
+    if (!allowedUrlSchemes.contains(scheme)) {
+        qCWarning(lcUtility) << "URL scheme is not allowed and has been rejected:" << url.toString();
         return false;
     }
 

src/gui/systray.cpp

@@ -16,6 +16,7 @@
 #include "configfile.h"
 #include "accessmanager.h"
 #include "callstatechecker.h"
+#include "guiutility.h"
 
 #include <QCursor>
 #include <QGuiApplication>
@@ -69,7 +70,12 @@
     _trayEngine->addImageProvider(QLatin1String("tray-image-provider"), new TrayImageProvider);
 }
 
+bool Systray::openUrlInBrowser(const QUrl &url) const
+{
+    return Utility::openBrowser(url);
+}
+
 Systray::Systray()
     : QSystemTrayIcon(nullptr)
 {
 #if defined(Q_OS_MACOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_14 && defined(BUILD_OWNCLOUD_OSX_BUNDLE)

src/gui/systray.h

@@ -113,6 +113,8 @@ class Systray : public QSystemTrayIcon
     void hideSettingsDialog();
 
 public slots:
+    [[nodiscard]] bool openUrlInBrowser(const QUrl &url) const;
+
     void setTrayEngine(QQmlApplicationEngine *trayEngine);
     void create();
 

src/gui/tray/CallNotificationDialog.qml

@@ -217,7 +217,7 @@ ApplicationWindow {
                         Layout.preferredHeight: Style.callNotificationPrimaryButtonMinHeight
 
                         onClicked: {
-                            Qt.openUrlExternally(modelData.link);
+                            Systray.openUrlInBrowser(modelData.link);
                             root.closeNotification();
                         }
 

src/gui/tray/MainWindow.qml

@@ -485,7 +485,7 @@ ApplicationWindow {
 
             activeFocusOnTab: true
             model: activityModel
-            onOpenFile: Qt.openUrlExternally(filePath);
+            onOpenFile: Systray.openUrlInBrowser(filePath);
             onActivityItemClicked: {
                 model.slotTriggerDefaultAction(index)
             }