fix(sharing): parse received timestamp from expiration date#9882
Merged
fix(sharing): parse received timestamp from expiration date#9882
Conversation
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
nilsding
added
bug
feature: 👥 sharing
Member
Author
|
/backport to stable-33.0 please |
Member
Author
|
/backport to stable-4.0 please |
camilasan
approved these changes
Apr 22, 2026
nilsding
force-pushed
the
bugfix/9859/sharedialog-parse-expiredate
branch
from
1633693 to
ec90cb8
Compare
Server version >= 33.0.1 changed the behaviour of the expiration date: instead of expiring shares at the beginning of the day, they now expire at the end of the day. The client previously relied on the expiry time being defined as `00:00:00`, this leads to the date unable to be parsed with the expiry time set to `23:59:59`. Solution: just™ parse the entire time returned from the server as well! The client sets the expiration date only as `YYYY-MM-DD` anyway, so it does not need to care about the time suggested by the server at all ... Resolves #9859 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
force-pushed
the
bugfix/9859/sharedialog-parse-expiredate
branch
from
ec90cb8 to
7ce6dd9
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9882.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Collaborator
|
going to ignore broken CI unrelated macOS missing check |
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server version >= 33.0.1 changed the behaviour of the expiration date: instead of expiring shares at the beginning of the day, they now expire at the end of the day.
The client previously relied on the expiry time being defined as
00:00:00, this leads to the date unable to be parsed with the expiry time set to23:59:59.Solution: just™ parse the entire time returned from the server as well! The client sets the expiration date only as
YYYY-MM-DDanyway, so it does not need to care about the time suggested by the server at all ...Resolves #9859