Skip to content

fix(discovery): do not sync shares with "Allow download and sync" unset#9963

Open
nilsding wants to merge 2 commits intomasterfrom
bugfix/noid/no-download-and-sync-folders
Open

fix(discovery): do not sync shares with "Allow download and sync" unset#9963
nilsding wants to merge 2 commits intomasterfrom
bugfix/noid/no-download-and-sync-folders

Conversation

@nilsding
Copy link
Copy Markdown
Member

@nilsding nilsding commented May 4, 2026

The option does not only apply to files, but also to folders.

Also: do not display shared items without that option in Windows on-demand folders

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

nilsding added 2 commits May 4, 2026 13:01
… permission

The permission does not only apply to files, but also to folders.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
otherwise cfapi would list folders that are skipped by the sync
engine itself

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding
Copy link
Copy Markdown
Member Author

nilsding commented May 4, 2026

/backport to stable-33.0

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9963.zip

Digest: sha256:a8b3cc3ecbbcdbcb48308098c014ffe744a1eb4e6af92a0581390af06f8e1679

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
98 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant