Skip to content

Conversation

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
…ssing api

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Copy link
Contributor Author

/backport to stable30

@SystemKeeper
Copy link
Contributor Author

/backport bc1c292 to stable29

@SystemKeeper
Copy link
Contributor Author

/backport bc1c292 to stable28

@SystemKeeper
Copy link
Contributor Author

SystemKeeper commented Nov 16, 2024

Now that I look at it again, I think the note about ratelimit is also wrong here and only belongs to the schedule endpoint?
And it seems that status is not an int, but a string?

image

@marcelklehr
Copy link
Member

Yes, well spotted! The POST should be a GET, the ratelimit should be for the schedule endpoint. For TaskProcessing the status is a string nowadays, indeed. Initially it was an int.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@rakekniven
Copy link
Member

@SystemKeeper Is it ok after rebasing?

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@rakekniven rakekniven requested a review from marcelklehr March 30, 2025 16:37
@SystemKeeper
Copy link
Contributor Author

That PR differs now from the original idea, let me take another look.

@rakekniven
Copy link
Member

rakekniven commented Mar 31, 2025

That PR differs now from the original idea, let me take another look.

I wasn't happy about the diff after updating branch.

@SystemKeeper Thank you

@SystemKeeper
Copy link
Contributor Author

The part I wanted to update, was removed and linked to the OpenAPI docs in 50948b9. That's why the diff now looks weird. We can close this then, the OpenAPI docs should be fine.
Thanks for taking a look @rakekniven !

@rakekniven rakekniven deleted the fix-get-task-by-id-method branch March 31, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants