-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix get task by id method #12371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get task by id method #12371
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
…ssing api Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
|
/backport to stable30 |
|
/backport bc1c292 to stable29 |
|
/backport bc1c292 to stable28 |
|
Yes, well spotted! The POST should be a GET, the ratelimit should be for the schedule endpoint. For TaskProcessing the status is a string nowadays, indeed. Initially it was an int. |
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
|
@SystemKeeper Is it ok after rebasing? |
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
|
That PR differs now from the original idea, let me take another look. |
I wasn't happy about the diff after updating branch. @SystemKeeper Thank you |
|
The part I wanted to update, was removed and linked to the OpenAPI docs in 50948b9. That's why the diff now looks weird. We can close this then, the OpenAPI docs should be fine. |

Refs:
https://github.com/nextcloud/server/blob/67a02fa611c8a88dc500cff2c93033bb3db436b7/core/Controller/TaskProcessingApiController.php#L162-L178
https://github.com/nextcloud/server/blob/67a02fa611c8a88dc500cff2c93033bb3db436b7/core/Controller/TextProcessingApiController.php#L140-L155
https://github.com/nextcloud/server/blob/67a02fa611c8a88dc500cff2c93033bb3db436b7/core/Controller/TextToImageApiController.php#L115-L132