Skip to content

Conversation

@stelzch
Copy link

@stelzch stelzch commented Nov 27, 2024

Using find -exec chmod … {} \; executes one process of chmod for every file/directory, whereas find -exec chmod … {} + collects files into a large list and invocates chmod much less.

☑️ Resolves

🖼️ Screenshots

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@rakekniven
Copy link
Member

@nickvergessen What do you think about this one here?

Using `find -exec chmod … {} \;`  executes one process of chmod for every file/directory, whereas `find -exec chmod … {} +` collects files into a large list and invocates chmod much less.

Signed-off-by: Christoph Stelz <mail@ch-st.de>
@blizzz
Copy link
Member

blizzz commented Apr 3, 2025

Question is whether we an run into a limit of arguments or length with find -exec chmod … {} +. The original version is safer, but I am not sure how risky it could be, and it may depend as well.

I'd keep it as is. When you know what you are doing, you can go with the + sign anyways.

@rakekniven rakekniven closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants