-
Notifications
You must be signed in to change notification settings - Fork 2.2k
explain v31 db row format warning #13086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7959748 to
8331bd5
Compare
| We have a new setup warning for MySQL and MariaDB databases if any tables are using a row format other than Dynamic. | ||
| This is likely true for older installations. | ||
| To resolve the warning, issue the proper ``ALTER TABLE`` DDL commands to change the row format during a maintenance window. | ||
| If you're not sure how to do this, you can `find some tips and tricks from the community <https://help.nextcloud.com/t/upgrade-to-nextcloud-hub-10-31-0-0-incorrect-row-format-found-in-your-database/218366/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| We have a new setup warning for MySQL and MariaDB databases if any tables are using a row format other than Dynamic. | |
| This is likely true for older installations. | |
| To resolve the warning, issue the proper ``ALTER TABLE`` DDL commands to change the row format during a maintenance window. | |
| If you're not sure how to do this, you can `find some tips and tricks from the community <https://help.nextcloud.com/t/upgrade-to-nextcloud-hub-10-31-0-0-incorrect-row-format-found-in-your-database/218366/>`_. | |
| Other row formats than ``DYNAMIC`` for MySQL and MariaDB databases will issue a warning since Nextcloud 24, | |
| as they often cause performance issues. | |
| With Nextcloud 31 a more prominent new setup warning for this was added. | |
| To resolve the warning, in most cases running ``occ db:convert-mysql-charset`` will resolve the issue. | |
| If some tables are not covered by the ``occ`` command, issuing the proper ``ALTER TABLE`` DDL commands to change the row format during a maintenance window is needed. | |
| If you're not sure how to do this, you can `find some tips and tricks from the community <https://help.nextcloud.com/t/upgrade-to-nextcloud-hub-10-31-0-0-incorrect-row-format-found-in-your-database/218366/>`_. |
Maybe something like this as its not a random setup warning but already a warning since Nextcloud 24 and based on performance issues.
Also the occ command is in most cases much simpler than custom scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you you @susnux ! Where did the warning appear before v31? It looks like it was added just recently. Oh never mind, I see it was the default for new installs, but yes, we just added the warning.
And thanks for mentioning that occ command, I didn't know about that.
I think I'll accept your suggestion and modify it slightly.
|
"Missing documentation" of nextcloud/server#48547 |
|
@meonkeys thank you for your pull request! |
8331bd5 to
d07085a
Compare
Signed-off-by: Adam Monsen <haircut@gmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Adam Monsen <haircut@gmail.com>
9cd847a to
de7c1ed
Compare
Signed-off-by: Adam Monsen <haircut@gmail.com>
aaf6d48 to
a8fe5b8
Compare
|
/backport to stable31 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
☑️ Resolves
There is no associated issue, just this PR.
🖼️ Screenshots