Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 25, 2025

☑️ Resolves

🖼️ Screenshots

image

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 25, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Jul 25, 2025

The occ db:convert-mysql-charset command changes the charset, not the ROW_FORMAT

It does both (if the table is in wrong charset):
https://github.com/nextcloud/server/blob/38768d1f8d8a0697c71580fa5821984bb10db7fe/lib/private/Repair/Collation.php#L62

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 25, 2025

if the table is in wrong charset

Which means it does not fix the problem from the warning.

And it is not its purpose according to the command description:
https://github.com/nextcloud/server/blob/38768d1f8d8a0697c71580fa5821984bb10db7fe/core/Command/Db/ConvertMysqlToMB4.php#L33

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 25, 2025

See also: nextcloud/server#34497 (comment)

@ShGKme ShGKme requested a review from kesselb July 25, 2025 18:08
@susnux
Copy link
Contributor

susnux commented Jul 25, 2025

yes sure - just wanted to point this out. As for most users their tables were created in a time where charset was wrong default and thus also their collation

@kesselb kesselb merged commit fcb3ec4 into master Jul 25, 2025
13 checks passed
@kesselb kesselb deleted the fix/admin_manual--release_notes--upgrade-31--db branch July 25, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants