Skip to content

fix PATH_INFO#1679

Merged
rullzer merged 1 commit intomasterfrom
jknockaert-patch-1
Oct 24, 2019
Merged

fix PATH_INFO#1679
rullzer merged 1 commit intomasterfrom
jknockaert-patch-1

Conversation

@jknockaert
Copy link
Contributor

try_files was added in #1674, but that resets $fastcgi_path_info. This PR makes sure PATH_INFO gets the original value.

`try_files` was added in #1674, but that resets `$fastcgi_path_info`. This PR makes sure PATH_INFO gets the original value.
@jknockaert jknockaert mentioned this pull request Oct 24, 2019
@rullzer
Copy link
Member

rullzer commented Oct 24, 2019

/backport to stable15

@rullzer
Copy link
Member

rullzer commented Oct 24, 2019

/backport to stable16

@rullzer
Copy link
Member

rullzer commented Oct 24, 2019

/backport to stable17

@jknockaert
Copy link
Contributor Author

@rullzer Would there be any need for a backport to the blog post?
https://nextcloud.com/blog/urgent-security-issue-in-nginx-php-fpm/

@rullzer rullzer merged commit 83022d8 into master Oct 24, 2019
@rullzer rullzer deleted the jknockaert-patch-1 branch October 24, 2019 20:30
@backportbot-nextcloud
Copy link

backport to stable15 in #1680

@rullzer
Copy link
Member

rullzer commented Oct 24, 2019

Yes will take care tomorrow
@jospoortvliet

@backportbot-nextcloud
Copy link

backport to stable16 in #1681

@backportbot-nextcloud
Copy link

backport to stable17 in #1682

@Starbix
Copy link

Starbix commented Oct 25, 2019

I think this should also be added to the blog entry.

@rullzer
Copy link
Member

rullzer commented Oct 25, 2019

Yeslike I said it will be added. However, having said that. For me my config works just fine without it as well.

skjnldsv added a commit to skjnldsv/docker-nextcloud-dev that referenced this pull request Oct 25, 2019
@jknockaert
Copy link
Contributor Author

@jknockaert I've been wondering if and where the php paramater PATH_INFO is used in nextcloud. But provided it is there in the nextcloud config file, we should make sure it doesn't change.

thelamer pushed a commit to linuxserver/docker-nextcloud that referenced this pull request Feb 7, 2020
* Bot Updating Package Versions

* fixed diffs w/ nextcloud upstream

Edit line 53, 67 - ocs-provider + ocm-provider, one call:
nextcloud/documentation@3206db9
nextcloud/documentation#1293

New line 55, edit 58 - try_files resets $fastcgi_path_info, fix so $path_info gets value:  
nextcloud/documentation@8f6c1aa
nextcloud/documentation#1679
thelamer pushed a commit to linuxserver/docker-nextcloud that referenced this pull request Feb 7, 2020
* php.ini and site config updates

* display real ip in nginx logs with rp

* fixed diffs w/ upstream nextcloud git (#129)

* Bot Updating Package Versions

* fixed diffs w/ nextcloud upstream

Edit line 53, 67 - ocs-provider + ocm-provider, one call:
nextcloud/documentation@3206db9
nextcloud/documentation#1293

New line 55, edit 58 - try_files resets $fastcgi_path_info, fix so $path_info gets value:  
nextcloud/documentation@8f6c1aa
nextcloud/documentation#1679

Co-authored-by: Evan Wade <evan+pgp@evanwade.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants